Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFA - Add support for overflow element #13554

Merged
merged 1 commit into from
Jun 15, 2021
Merged

XFA - Add support for overflow element #13554

merged 1 commit into from
Jun 15, 2021

Conversation

calixteman
Copy link
Contributor

  • and fix few bugs:
    • avoid infinite loop when layout the document;
    • avoid confusion between break and layout failure;
    • don't add margin width in tb layout when getting available space.

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a12dc19f6d2382e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/bec2c87de13b07d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/bec2c87de13b07d/output.txt

Total script time: 5.71 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/bec2c87de13b07d/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/a12dc19f6d2382e/output.txt

Total script time: 27.31 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/a12dc19f6d2382e/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/275afd506d123df/output.txt

@brendandahl
Copy link
Contributor

@calixteman looks like some ref tests failed with this PR

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/275afd506d123df/output.txt

Total script time: 5.00 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/275afd506d123df/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

Wiped out the bad cached file, let's try this again.
/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/08c77885ab8bcb2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/08c77885ab8bcb2/output.txt

Total script time: 32.06 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/08c77885ab8bcb2/reftest-analyzer.html#web=eq.log

@calixteman
XFA - Add support for overflow element
0ea5792 
  - and fix few bugs:
    - avoid infinite loop when layout the document;
    - avoid confusion between break and layout failure;
    - don't add margin width in tb layout when getting available space.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e5c8c535c24ff48/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/4d0c09749ee16a7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/e5c8c535c24ff48/output.txt

Total script time: 27.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/e5c8c535c24ff48/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/4d0c09749ee16a7/output.txt

Total script time: 30.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/4d0c09749ee16a7/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/97d311abfe95477/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/6cb68dd4609c605/output.txt

@brendandahl brendandahl merged commit f9a0568 into mozilla:master Jun 15, 2021
@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/97d311abfe95477/output.txt

Total script time: 23.98 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/6cb68dd4609c605/output.txt

Total script time: 28.67 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus
Copy link
Collaborator

@brendandahl It looks like this regressed at least xfa_imm1344e-page1 in all browsers/platforms, and possibly the rest of that file as well, why was this landed as-is?

@brendandahl
Copy link
Contributor

I mixed up the refs for that one (thought it was improving). Calixte has a fix in progress, so we'll just re-run with the fix.

calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 16, 2021
@calixteman
XFA - Fix layout issues
08bd76d 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
@calixteman calixteman mentioned this pull request Jun 16, 2021
Merged
@marco-c marco-c mentioned this pull request Jun 16, 2021
Closed
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 16, 2021
@calixteman
XFA - Fix layout issues
d2fdc03 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 16, 2021
@calixteman
XFA - Fix layout issues
3efa922 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
@timvandermeij timvandermeij removed the request for review from brendandahl June 16, 2021 17:51
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 16, 2021
@calixteman
XFA - Fix layout issues
5e52c5b 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 17, 2021
@calixteman
XFA - Fix layout issues
4922c25 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 17, 2021
@calixteman
XFA - Fix layout issues
681401f 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 17, 2021
@calixteman
XFA - Fix layout issues
df08b15 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
bh213 pushed a commit to bh213/pdf.js that referenced this pull request Jun 3, 2022
@calixteman @bh213
XFA - Fix layout issues
ad201bf 
  - PR mozilla#13554 is buggy, so this patch aims to fix bugs.
  - check if a component fits into its parent in taking into account the parent layout.
  - introduce method isSplittable for template nodes to know if a component can be splitted in case of overflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calixteman @brendandahl @pdfjsbot @Snuffleupagus @marco-c